🔁

Lend vs borrow: same label?

Discussion started , with a comment.
  1. F5f0b07dbf314270d68fee0d9c833a3e
    Thomas Malbaux French Translator with all proofreading rights

    Is it correct that "event_feed_events.accept.has_accepted_lend_item" (https://webtranslateit.com/en/projects/2056-Kassi/locales/en..fr/strings/1995562) has the same text label than "event_feed_events.accept.has_accepted_borrow_item" (https://webtranslateit.com/en/projects/2056-Kassi/locales/en..fr/strings/1995563?current_id=1995563)?

    Seems to be the same in finnish, english...
    I guess it is in order to simplify things?

    Thx.
    Thomas.

  2. 9d82d62655f10c14ad4623ad839f1585
    Antti Virolainen

    Yea this is bit confusin, but it's due that we store the direction of who "gives" and who "gets" (affects e.g. some badges) and the giver is always first, so even if the original listing was borrow request or lend offer, the text is the same and the positions of names just swithced. We still need the two strings to be able to build the string key straightfrom the type of listing.
    Although, now comes to mind some solutions to avoid this duplication... Well, anyway follow the english model. :)


History

  1. agreed to lend
    agreed to lend

    agreed to lend

    changed by Antti Virolainen .
    Copy to clipboard
  2. agreed to lend
    agreed to lend

    agreed to lend

    changed by Antti Virolainen .
    Copy to clipboard
  3. %{offerer_name} agreed to lend %{listing_title} to %{requester_name}
    %{offerer_name} agreed to lend %{listing_title} to %{requester_name}

    %{offerer_name} agreed to lend %{listing_title} to %{requester_name}

    changed by Antti Virolainen .
    Copy to clipboard
  4. %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.
    %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.

    %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.

    changed by Antti Virolainen .
    Copy to clipboard
  5. %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.
    %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.

    %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.

    changed by Juho Makkonen .
    Copy to clipboard
  6. %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name}'e ödünç vermeyi kabul etti.
    %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name}'e ödünç vermeyi kabul etti.
    changed by Anilatilgan .
    Copy to clipboard
  7. %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name}'e ödünç vermeyi kabul etti.
    %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name}'e ödünç vermeyi kabul etti.
    changed by Timur Catakli .
    Copy to clipboard
  8. %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name}'e ödünç vermeyi kabul etti.
    %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name}'e ödünç vermeyi kabul etti.
    changed by Timur Catakli .
    Copy to clipboard
  9. %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name} üyesine ödünç vermeyi kabul etti.
    %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name} üyesine ödünç vermeyi kabul etti.
    changed by Timur Catakli .
    Copy to clipboard
  10. %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name} üyesine ödünç vermeyi kabul etti.
    %{offerer_name} %{time_ago}%{listing_title}'ı %{requester_name} üyesine ödünç vermeyi kabul etti.
    changed by Timur Catakli .
    Copy to clipboard