🔁

Lend vs borrow: same label?

Discussion commencée , avec un commentaire.
  1. Thomas Malbaux Traducteur en français ayant un droit de relecture total (incluant ses propres traductions)

    Is it correct that "event_feed_events.accept.has_accepted_lend_item" (https://webtranslateit.com/en/projects/2056-Kassi/locales/en..fr/strings/1995562) has the same text label than "event_feed_events.accept.has_accepted_borrow_item" (https://webtranslateit.com/en/projects/2056-Kassi/locales/en..fr/strings/1995563?current_id=1995563)?

    Seems to be the same in finnish, english...
    I guess it is in order to simplify things?

    Thx.
    Thomas.

  2. Yea this is bit confusin, but it's due that we store the direction of who "gives" and who "gets" (affects e.g. some badges) and the giver is always first, so even if the original listing was borrow request or lend offer, the text is the same and the positions of names just swithced. We still need the two strings to be able to build the string key straightfrom the type of listing.
    Although, now comes to mind some solutions to avoid this duplication... Well, anyway follow the english model. :)


Historique

  1. agreed to lend
    agreed to lend

    agreed to lend

    modifié par Antti Virolainen .
    Copier dans le presse-papier
  2. agreed to lend
    agreed to lend

    agreed to lend

    modifié par Antti Virolainen .
    Copier dans le presse-papier
  3. %{offerer_name} agreed to lend %{listing_title} to %{requester_name}
    %{offerer_name} agreed to lend %{listing_title} to %{requester_name}

    %{offerer_name} agreed to lend %{listing_title} to %{requester_name}

    modifié par Antti Virolainen .
    Copier dans le presse-papier
  4. %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.
    %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.

    %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.

    modifié par Antti Virolainen .
    Copier dans le presse-papier
  5. %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.
    %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.

    %{offerer_name} agreed to lend %{listing_title} to %{requester_name} %{time_ago}.

    modifié par Juho Makkonen .
    Copier dans le presse-papier
  6. %{offerer_name} se je strinjal, da bo %{listing_title} posodil %{requester_name} %{time_ago}.
    %{offerer_name} se je strinjal, da bo %{listing_title} posodil %{requester_name} %{time_ago}.
    modifié par Aljaz .
    Copier dans le presse-papier